Viewport sRGB isn't correct

Question

Viewport sRGB isn't correct

DEF7 opened this issue 6 years ago · comments

Hi again. I was doing some OpenVR/OculusVR performance experiments running the same project on my Rift via the Oculus module and the OpenVR module and discovered that the eye textures being submitted to the Oculus VR API are not properly sRGB-spaced. I had the same issue implementing Oculus into my engine and it took a bit of fandangling to get it working right. Projects using the Oculus module look noticably brighter and washed out compared to what's rendered on the screen, whereas OpenVR projects match the coloring of the render on the screen and in the editor.

IIRC I had to set my engine up so that it rendered normally and then I blit the rendered scene to an FBO with the swapchain textures attached while GL_FRAMEBUFFER_SRGB was enabled. It was very confusing and took me an hour to figure out.

Bastiaan Olij · Answer 1 · Wed Apr 25 2018 08:28:02 GMT+0800 (China Standard Time)

Thanks!! I am going to try that out tonight when i’m home, i figured it was an issue with tone mapping but if it is as simple as changing the frame buffer that would be cool:)

On Wed, 25 Apr 2018 at 6:49 am, Charles Van Noland ***@***.***> wrote: Hi again. I was doing some OpenVR/OculusVR performance experiments running the same project on my Rift via the Oculus module and the OpenVR module and discovered that the eye textures being submitted to the Oculus VR API are not properly sRGB-spaced. I had the same issue implementing Oculus into my engine and it took a bit of fandangling to get it working right. Projects using the Oculus module look noticably brighter and washed out compared to what's rendered on the screen, whereas OpenVR projects match the coloring of the render on the screen and in the editor. IIRC I had to set my engine up so that it rendered normally and then I blit the rendered scene to an FBO with the swapchain textures attached while GL_FRAMEBUFFER_SRGB was enabled. It was very confusing and took me an hour to figure out. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#11>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AB2vaQdg9vKhsBs0hQqn84jBxXnvbdf7ks5tr4_ogaJpZM4TiZOt> .

-- Kindest regards, Bastiaan Olij https://www.facebook.com/bastiaan.olij https://twitter.com/mux213 https://www.youtube.com/channel/UCrbLJYzJjDf2p-vJC011lYw https://github.com/BastiaanOlij

Bastiaan Olij · Answer 2 · Wed Apr 25 2018 16:05:17 GMT+0800 (China Standard Time)

Wow! works like a charm! So the enable GL_FRAMEBUFFER_SRGB turns on converting from linear colour space to SRGB colour space. But Godot already is using the correct colour space. Not enabling it (copied that out of the oculus demos I think) solves the colour issues. COOL.

Deftware · Answer 3 · Wed Apr 25 2018 16:31:56 GMT+0800 (China Standard Time)

Cool!

…

On Wed, Apr 25, 2018 at 1:10 AM, Bastiaan Olij ***@***.***> wrote: Closed #11 <#11>. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#11 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ALBg9bP2e26pxUY_IMalAgteT1eCZcy_ks5tsC9bgaJpZM4TiZOt> .

Bastiaan Olij · Answer 4 · Wed Apr 25 2018 17:02:17 GMT+0800 (China Standard Time)

See if it works for you :)

Deftware · Answer 5 · Wed Apr 25 2018 19:28:57 GMT+0800 (China Standard Time)

Yup, everything looks great now ;) Thanks!

…

On Wed, Apr 25, 2018 at 2:02 AM, Bastiaan Olij ***@***.***> wrote: See if it works for you :) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#11 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ALBg9aEcJt9mM_zY0uBUIon4XngBzyw1ks5tsDufgaJpZM4TiZOt> .