Request missing parameters for add-contact command - [merged]
kwannoel opened this issue · comments
In GitLab by @kwanzknoel on Sep 17, 2021, 03:44
Merges kwannoel/prompt-missing-params -> master
Request for missing parameters for glow add-contact command.
Part of https://gitlab.com/mukn/glow/-/issues/218.
Previous behaviour for missing name option:
~/projects/glow/cli $ ../glow add-contact
Glow 0.3.1-2-g311b807 on Gerbil-ethereum v0.0-344-g266204c, Gerbil-persist v0.0-19-g75d4c45, Gerbil-crypto v0.0-16-g4c7c4a8, Gerbil-poo v0.0-96-g8ab28ef, Gerbil-utils v0.2-134-g124e025, Gerbil v0.16-192-gfa9537be, Gambit 4.9.3-1447-gc0753ff1
In thread primordial:
0 mukn/glow/cli/contacts#add-contact__%
1 ##dynamic-env-bind
2 ##call-with-values
3 clan/exit#call-print-exit
4 ##dynamic-env-bind
5 ##start-main
6 ##kernel-handlers
*** ERROR IN mukn/glow/cli/contacts#add-contact__% -- missing name
Improved behaviour for missing name option:
~/projects/glow/cli $ ../glow add-contact
Enter contact name:
> alice
Added contact alice, cid 23
Will continue to fix other entry-points (add-identity etc...) if this approach works.
In GitLab by @kwanzknoel on Sep 17, 2021, 03:45
changed the description
In GitLab by @kwanzknoel on Sep 17, 2021, 03:46
changed the description
In GitLab by @kwanzknoel on Sep 17, 2021, 03:49
added 1 commit
- 913af9e5 - Request missing parameters for add-contact command
In GitLab by @kwanzknoel on Sep 17, 2021, 03:52
added 1 commit
- cf280cf9 - Request missing parameters for add-contact command
In GitLab by @kwanzknoel on Sep 17, 2021, 03:53
added 1 commit
- 913af9e5 - Request missing parameters for add-contact command
In GitLab by @kwanzknoel on Sep 17, 2021, 03:56
Commented on cli/interaction.ss line 257
Duplicate options declared here.
See the above lines 247-250: https://gitlab.com/mukn/glow/-/merge_requests/178/diffs?commit_id=913af9e5b6d9dcbe6c8aa3d5ef02dd98ce138cab#e8ca1550e3510a9351de1eb1c2562e7457e94cea_247_235
In GitLab by @kwanzknoel on Sep 17, 2021, 03:58
changed the description
In GitLab by @kwanzknoel on Sep 17, 2021, 05:09
changed the description
In GitLab by @kwanzknoel on Sep 17, 2021, 05:09
changed the description
In GitLab by @kwanzknoel on Sep 17, 2021, 05:11
added 1 commit
- 20c751b - Request missing parameters for add-contact command
In GitLab by @kwanzknoel on Sep 17, 2021, 05:11
changed the description
In GitLab by @fahree on Sep 17, 2021, 20:49
Commented on cli/contacts.ss line 63
This is possible. We could add some metadata to define-entry-point. Also a parameter for debugging.
In GitLab by @kwanzknoel on Sep 17, 2021, 22:51
resolved all threads