Default initial-block-number to current-block-number - [merged]
kwannoel opened this issue · comments
In GitLab by @kwanzknoel on Sep 11, 2021, 02:47
Merges kwannoel/default-block-number -> master
Defaults the initial-block-number to current-block-number, instead of terminating the entire interaction.
In GitLab by @plotnick on Sep 11, 2021, 03:47
Commented on cli/interaction.ss line 206
Couldn't we call ask-number here? That way the underlying logic is only in one place.
In GitLab by @kwanzknoel on Sep 11, 2021, 05:23
Commented on cli/interaction.ss line 206
Yes, ask-number is not used anywhere else it seems.
On top of that I think the program should also error out if the input is non-empty and not a number.
The default case should only hold when input is empty.
Will fix these.
In GitLab by @fahree on Sep 13, 2021, 05:10
Commented on cli/interaction.ss line 215
Call it default- instead of def- characters are cheap, whereas ambiguity with define isn't.
In GitLab by @kwanzknoel on Sep 14, 2021, 00:45
Commented on cli/interaction.ss line 206
changed this line in version 2 of the diff
In GitLab by @kwanzknoel on Sep 14, 2021, 00:45
Commented on cli/interaction.ss line 206
changed this line in version 2 of the diff
In GitLab by @kwanzknoel on Sep 14, 2021, 00:45
Commented on cli/interaction.ss line 215
changed this line in version 2 of the diff
In GitLab by @kwanzknoel on Sep 14, 2021, 00:45
added 3 commits
- f04beacb...b8062a3b - 2 commits from branch
master - a0256af - Default initial-block-number to current-block-number
In GitLab by @fahree on Sep 14, 2021, 05:33
LGTM.
If there's extra functionality you want, it's fine to add a TODO... technical debt!
In GitLab by @kwanzknoel on Sep 15, 2021, 01:58
resolved all threads