Fix Param Parser for nullary functions - [merged]
kwannoel opened this issue · comments
In GitLab by @kwanzknoel on May 26, 2021, 01:54
Merges noel/fix-param -> master
Part of fixing #190.
Params now parses the parameter list of nullary functions into the form:
'() instead of '(#f).
In GitLab by @kwanzknoel on May 26, 2021, 01:57
added 1 commit
- b0052205 - Fix Param Parser for nullary functions
In GitLab by @kwanzknoel on May 26, 2021, 02:15
added 1 commit
- cb8b6651 - Fix Param Parser for nullary functions
In GitLab by @fahree on May 26, 2021, 05:16
Commented on compiler/parse/expressions.ss line 447
Generally LGTM.
shouldn't there be a sepby0 or something that does that? Maybe one that also has a terminator parameter in case that's required for efficient parsing?
In GitLab by @kwanzknoel on May 26, 2021, 18:55
Commented on compiler/parse/expressions.ss line 447
changed this line in version 4 of the diff
In GitLab by @kwanzknoel on May 26, 2021, 18:55
added 1 commit
- cc04dc59 - Fix Param Parser for nullary functions
In GitLab by @kwanzknoel on May 26, 2021, 18:57
changed the description
In GitLab by @kwanzknoel on May 26, 2021, 18:58
resolved all threads
In GitLab by @kwanzknoel on May 26, 2021, 19:00
Commented on compiler/parse/expressions.ss line 447
Alright updated. The issue was with the Param parser. It did not FAIL and instead returned #f when an identifier was missing.
In GitLab by @kwanzknoel on May 26, 2021, 19:03
Commented on compiler/parse/expressions.ss line 447
Hence using the old Param parser with sepby (which I think is what you meant by sepby0) would also return '(#f).
In GitLab by @kwanzknoel on May 26, 2021, 19:03
resolved all threads