Support HTML (Ruby - ERB)

Question

Support HTML (Ruby - ERB)

borisdamato opened this issue 10 years ago · comments

When I try to beautify an html.erb file, atom returns the "Unsupported language for grammar 'HTML (Ruby - ERB)'." error. Since html.erb is just a simple html file with embed ruby, could it be possibile to support it?

Glavin Wiechert · Answer 1 · Mon Sep 08 2014 20:18:35 GMT+0800 (China Standard Time)

Absolutely! Thanks for letting me know.

Here is the afflicting line of code: https://github.com/Glavin001/atom-beautify/blob/master/lib/language-options.coffee#L148

Change

when "HTML (Liquid)", "HTML", "XML"

to

when "HTML (Liquid)", "HTML", "XML", "HTML (Ruby - ERB)"

And it will also handle that grammar for .erb files.

I will try and publish a patch after work tonight.

Glavin Wiechert · Answer 2 · Mon Sep 08 2014 20:35:43 GMT+0800 (China Standard Time)

@Aselox could post a sample html.erb file contents? I am going to quickly patch it now, test, and publish.

Also it may be worth while to switch from js-beautify to https://github.com/threedaymonk/htmlbeautifier for HTML beautification support.

Glavin Wiechert · Answer 3 · Mon Sep 08 2014 20:37:46 GMT+0800 (China Standard Time)

beautify-web/js-beautify#398 would suggest that ERB support is not available with js-beautify.

It may be best to add ERB support and use https://github.com/threedaymonk/htmlbeautifier just for it.

Boris D'Amato · Answer 4 · Mon Sep 08 2014 20:42:12 GMT+0800 (China Standard Time)

@Glavin001 I renamed the file I'm working on removing the .erb part and I noticed the same bug described in that report. It seems to break ruby code by adding spaces between @ or models.
Eg: @user.username -> @ user.username (or) User.find_by_id -> U ser.find_by_id

Glavin Wiechert · Answer 5 · Mon Sep 08 2014 20:43:45 GMT+0800 (China Standard Time)

Could you try htmlbeautifier and let me know if it works for you? If it works as expected in all of your usages then I can add support for it later today 👍.

Boris D'Amato · Answer 6 · Mon Sep 08 2014 21:24:18 GMT+0800 (China Standard Time)

Ok @Glavin001, I tried htmlbeautifier multiple times and it seems to work really well without breaking the embed ruby code.

Glavin Wiechert · Answer 7 · Mon Sep 08 2014 22:01:27 GMT+0800 (China Standard Time)

Excellent! Then I should be able to add support for ERB HTML later. I'll see if I can tonight, if not soon after. Thanks for testing!

Glavin Wiechert · Answer 8 · Tue Sep 09 2014 04:17:45 GMT+0800 (China Standard Time)

I took the example from: http://www.stuartellis.eu/articles/erb/

<DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN"
    "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">

    <html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
    <head>
            <meta http-equiv="Content-Type" content="text/html; charset=utf-8"/>
            <title>Shopping List for <%= @date.strftime('%A, %d %B %Y') %></title>
        </head>
        <body>
                 <h1>Shopping List for <%= @date.strftime('%A, %d %B %Y') %></h1>
                <p>You need to buy:</p>
                <ul>
                  <% for @item in @items %>
                    <li><%= h(@item) %></li>
                  <% end %>
                </ul>
        </body>
        </html>

<DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN"
    "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
  <html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
    <head>
      <meta http-equiv="Content-Type" content="text/html; charset=utf-8"/>
      <title>Shopping List for
        <%= @date.strftime('%A, %d %B %Y') %></title>
    </head>
    <body>
      <h1>Shopping List for
        <%= @date.strftime('%A, %d %B %Y') %></h1>
      <p>You need to buy:</p>
      <ul>
        <% for @item in @items %>
        <li><%= h(@item) %></li>
      <% end %>
    </ul>
  </body>
</html>

Will be publishing soon now that I have it working and tested 👍.

Glavin Wiechert · Answer 9 · Tue Sep 09 2014 05:51:29 GMT+0800 (China Standard Time)

Published to v0.8.0