GitHawkApp / MessageViewController

A SlackTextViewController replacement written in Swift for the iPhone X.

Home Page:http://githawk.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Add accessibility information to the send button

BasThomas opened this issue · comments

I did not know that you could inspect the simulator like this! Very cool.

@BasThomas should we just be assigning the AX properties here?

https://github.com/GitHawkApp/MessageViewController/blob/master/MessageViewController/MessageView.swift#L132-L142

Or like what info are we missing?

Yeah, the only tricky thing is that at that point they would always be tied to the information passed into the function — if someone would want a different accessibilityLabel than the title, they would not be able to do so.

So we could add an optional parameter that would override the accessibilityLabel, just not sure if that's scalable enough / overkill.

commented

I think that will be the proper way to set AX labels. You can suggest a potential implementation and do a pull request.