GitHawkApp / MessageViewController

A SlackTextViewController replacement written in Swift for the iPhone X.

Home Page:http://githawk.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Do an accessibility audit

BasThomas opened this issue · comments

Check if the elements are properly accessible in VoiceOver and improve if needed.

I've completed an audit. I'm not finding a whole lot!

I did notice the text view is behaving in a funky fashion. Tapping it to focus it, it only reads the line of text that you tapped, rather than the entire text view content. Comparing that to Messages, when you tap in the the text view, it reads the entire contents. Note that when you don't tap in the text view but rather swipe between elements, it properly highlights the entire text view and reads it all.

When there's no text in the text view, it's odd that you can select the placeholder and the text view separately. In Messages, the placeholder behaves as part of the text view. (I know, wouldn't it be nice if there were native placeholder APIs for UITextView..)

The attachment button doesn't do anything, but it also doesn't do anything when not using VO.

With the auto complete thingy, each cell in the table ought to be given the button trait. When you type an @, should the focus be moved, or an announcement posted to indicate suggestions are available? If you select the first suggestion, then swipe left, focus moves to element located underneath the autocomplete view, which feels funky. After activating one of the auto complete suggestions, focus should move back to the text view - currently it focuses on whatever was underneath it.

That is an awesome audit, thanks @hipwelljo! Also, I think we can and should look into fixing all of the points you mentioned.

Is this something you want to take a look at? Maybe create separate issues for all of the points?

I'll go ahead and create separate issues. I'm not sure how exactly to solve them atm though, and likely won't have time to look into it unfortunately.

Don’t worry! Thanks so much for reporting. Closing this in favor of the more granular tickets.

Sent with GitHawk