GhostPack / SharpUp

SharpUp is a C# port of various PowerUp functionality.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Incorrect name of the ModifiableScheduledTask parameter.

hasksomatotoian opened this issue · comments

Steps to Reproduce

Run SharpUp with the ModifiableScheduledTask parameter and verify that no checks were run:

[*] Audit mode: running an additional 0 check(s).

Root Cause of the Issue

That's because the check class is named differently, ModifiableScheduledTaskFile (notice the File at the end), so the ModifiableScheduledTask parameter does not invoke it.

Proposed Solution

There are two options for solving this:

  • Rename the parameter in the documentation from ModifiableScheduledTask to ModifiableScheduledTaskFile
  • Rename the check class to ModifiableScheduledTask

I propose choosing the latter option, as it is a quick internal change and people won't have to modify their scripts and checklists (even if they haven't worked so far).