precompile of GB-project fails: "some other module mutating `Stipple` with `eval` during precompilation - don't do this."

Question

precompile of GB-project fails: "some other module mutating `Stipple` with `eval` during precompilation - don't do this."

michaelfliegner opened this issue a year ago · comments

I want to deploy my Genie Builder Project to julia hub. Precompile fails with error below.
Source is
https://github.com/Actuarial-Sciences-for-Africa-ASA/GenieBuiltLifeProto
You can, however, run the app - in gitpod, for example, with a preloaded postgres db.
by

include("run.jl")

Code is developped with and runs under GenieBuilder, all I changed is, add this module
https://github.com/Actuarial-Sciences-for-Africa-ASA/GenieBuiltLifeProto/blob/main/src/GenieBuiltLifeProto.jl

Failed to precompile GenieBuiltLifeProto [9e6ec31a-4cef-4def-9440-f7db695aa5a5] to /home/gitpod/.julia/compiled/v1.8/GenieBuiltLifeProto/jl_VjC2Gc.
ERROR: LoadError: Evaluation into the closed module `Stipple` breaks incremental compilation because the side effects will not be permanent. This is likely due to some other module mutating `Stipple` with `eval` during precompilation - don't do this.
Stacktrace:
 [1] eval
   @ ./boot.jl:368 [inlined]
 [2] binding(expr::Expr, m::Module, mode::Any; source::LineNumberNode, reactive::Bool)
   @ Stipple.ReactiveTools ~/.julia/packages/Stipple/XoQ2b/src/ReactiveTools.jl:274
 [3] var"@out"(__source__::LineNumberNode, __module__::Module, expr::Any)
   @ Stipple.ReactiveTools ~/.julia/packages/Stipple/XoQ2b/src/ReactiveTools.jl:361
 [4] include(mod::Module, _path::String)
   @ Base ./Base.jl:419
 [5] include(x::String)
   @ GenieBuiltLifeProto /workspace/GenieBuiltLifeProto/src/GenieBuiltLifeProto.jl:1
 [6] top-level scope
   @ /workspace/GenieBuiltLifeProto/src/GenieBuiltLifeProto.jl:6
 [7] include
   @ ./Base.jl:419 [inlined]
 [8] include_package_for_output(pkg::Base.PkgId, input::String, depot_path::Vector{String}, dl_load_path::Vector{String}, load_path::Vector{String}, concrete_deps::Vector{Pair{Base.PkgId, UInt64}}, source::Nothing)
   @ Base ./loading.jl:1554
 [9] top-level scope
   @ stdin:1
in expression starting at /workspace/GenieBuiltLifeProto/app.jl:26
in expression starting at /workspace/GenieBuiltLifeProto/app.jl:1
in expression starting at /workspace/GenieBuiltLifeProto/src/GenieBuiltLifeProto.jl:1
in expression starting at stdin:1

hhaensel · Answer 1 · Sun Apr 30 2023 15:22:50 GMT+0800 (China Standard Time)

Not sure whether that solves it (currentlyon my mobile), but try to replace @handlers by @app

Michael Fliegner · Answer 2 · Sun Apr 30 2023 20:31:45 GMT+0800 (China Standard Time)

Will try that this evening. Thankful for your quick response🙏

Michael Fliegner · Answer 3 · Mon May 01 2023 01:10:09 GMT+0800 (China Standard Time)

Unfortuantely, that wasn´t it: error remains:

(GenieBuiltLifeProto) pkg> precompile
Precompiling project...
✗ GenieBuiltLifeProto
0 dependencies successfully precompiled in 43 seconds. 216 already precompiled.

ERROR: The following 1 direct dependency failed to precompile:

GenieBuiltLifeProto [9e6ec31a-4cef-4def-9440-f7db695aa5a5]

Failed to precompile GenieBuiltLifeProto [9e6ec31a-4cef-4def-9440-f7db695aa5a5] to /home/gitpod/.julia/compiled/v1.8/GenieBuiltLifeProto/jl_dX4Zu3.
ERROR: LoadError: Evaluation into the closed module Stipple breaks incremental compilation because the side effects will not be permanent. This is likely due to some other module mutating Stipple with eval during precompilation - don't do this.
Stacktrace:
[1] eval
@ ./boot.jl:368 [inlined]
[2] binding(expr::Expr, m::Module, mode::Any; source::LineNumberNode, reactive::Bool)
@ Stipple.ReactiveTools ~/.julia/packages/Stipple/XoQ2b/src/ReactiveTools.jl:274
[3] var"@out"(source::LineNumberNode, module::Module, expr::Any)
@ Stipple.ReactiveTools ~/.julia/packages/Stipple/XoQ2b/src/ReactiveTools.jl:361
[4] include(mod::Module, _path::String)
@ Base ./Base.jl:419
[5] include(x::String)
@ GenieBuiltLifeProto /workspace/GenieBuiltLifeProto/src/GenieBuiltLifeProto.jl:1
[6] top-level scope
@ /workspace/GenieBuiltLifeProto/src/GenieBuiltLifeProto.jl:6
[7] include
@ ./Base.jl:419 [inlined]
[8] include_package_for_output(pkg::Base.PkgId, input::String, depot_path::Vector{String}, dl_load_path::Vector{String}, load_path::Vector{String}, concrete_deps::Vector{Pair{Base.PkgId, UInt64}}, source::Nothing)
@ Base ./loading.jl:1554
[9] top-level scope
@ stdin:1
in expression starting at /workspace/GenieBuiltLifeProto/app.jl:26
in expression starting at /workspace/GenieBuiltLifeProto/app.jl:1
in expression starting at /workspace/GenieBuiltLifeProto/src/GenieBuiltLifeProto.jl:1
in expression starting at stdin:1

(GenieBuiltLifeProto) pkg>

hhaensel · Answer 4 · Mon May 01 2023 01:14:12 GMT+0800 (China Standard Time)

Will try to have a look tonight.

hhaensel · Answer 5 · Mon May 01 2023 04:42:34 GMT+0800 (China Standard Time)

I just published a branch hh-precompile to address the issue.
Would you be so kind and test with that branch?

] add Stipple#hh-precompile

hhaensel · Answer 6 · Mon May 01 2023 05:44:52 GMT+0800 (China Standard Time)

When I wrote this I was just learning about macro programming and was not aware about this kind of dos and don'ts.
Meanwhile I am, although I am still learning...

Michael Fliegner · Answer 7 · Mon May 01 2023 14:18:30 GMT+0800 (China Standard Time)

I am on stand-by

hhaensel · Answer 8 · Tue May 02 2023 14:34:26 GMT+0800 (China Standard Time)

There's more to it, I'll let you know when there are essential news.

Michael Fliegner · Answer 9 · Tue May 02 2023 19:17:07 GMT+0800 (China Standard Time)

Mille grazie hhaensel ***@***.***> schrieb am Di., 2. Mai 2023, 08:34:

…

There's more to it, I'll let you know when there are essential news. — Reply to this email directly, view it on GitHub <#194 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC6Y2USW2WPGKRMW7ZGPI6TXECTH3ANCNFSM6AAAAAAXQXCAQY> . You are receiving this because you authored the thread.Message ID: ***@***.***>

hhaensel · Answer 10 · Wed May 03 2023 00:06:52 GMT+0800 (China Standard Time)

You can try now. I built a MWE for myself and that passes with two warnings. The warnings result from the fact that we allow for redefinition of apps, so they are there by design.

Michael Fliegner · Answer 11 · Wed May 03 2023 01:31:00 GMT+0800 (China Standard Time)

(GenieBuiltLifeProto) pkg> status Stipple
Project GenieBuiltLifeProto v0.1.0
Status ~/dev/julia_depot/geniebuilder/apps/GenieBuiltLifeProto/Project.toml
[4acbeb90] Stipple v0.26.3 https://github.com/GenieFramework/Stipple.jl.git#hh-precompile

(GenieBuiltLifeProto) pkg> update Stipple
Updating registry at ~/dev/julia_depot/registries/General.toml
Updating git-repo https://github.com/GenieFramework/Stipple.jl.git
Installed StaticArrays ─── v1.5.24
Installed GeometryBasics ─ v0.4.7
Installed Distributions ── v0.25.88
Updating ~/dev/julia_depot/geniebuilder/apps/GenieBuiltLifeProto/Project.toml
[4acbeb90] ~ Stipple v0.26.3 https://github.com/GenieFramework/Stipple.jl.git#hh-precompile ⇒ v0.26.3 https://github.com/GenieFramework/Stipple.jl.git#hh-precompile
Updating ~/dev/julia_depot/geniebuilder/apps/GenieBuiltLifeProto/Manifest.toml
[31c24e10] ↑ Distributions v0.25.87 ⇒ v0.25.88
[5c1252a2] ↑ GeometryBasics v0.4.6 ⇒ v0.4.7
[90137ffa] ↑ StaticArrays v1.5.23 ⇒ v1.5.24
[4acbeb90] ~ Stipple v0.26.3 https://github.com/GenieFramework/Stipple.jl.git#hh-precompile ⇒ v0.26.3 https://github.com/GenieFramework/Stipple.jl.git#hh-precompile
[3bb67fe8] ↑ TranscodingStreams v0.9.12 ⇒ v0.9.13
Precompiling project...
29 dependencies successfully precompiled in 232 seconds. 188 already precompiled.

Michael Fliegner · Answer 12 · Wed May 03 2023 01:55:16 GMT+0800 (China Standard Time)

will You close the issue after merging into the main branch?

hhaensel · Answer 13 · Wed May 03 2023 02:55:43 GMT+0800 (China Standard Time)

Happy that it works for you as well. Have you also tested functionality?

Michael Fliegner · Answer 14 · Wed May 03 2023 15:05:09 GMT+0800 (China Standard Time)

ja, läuft.