shows as warning regardless of rules declaration

[Tyler Haas]

I have setup my tslint.json like this:

{
  "defaultSeverity": "error",
  "extends": ["tslint-config-airbnb", "tslint-react-hooks"],
  "jsRules": {},
  "rules": {
    "align": false,
    "import-name": false,
    "no-boolean-literal-compare": false,
    "no-this-assignment": false,
    "react-hooks-nesting": "error",
    "variable-name": false,
    "ter-indent": false,
    "ter-arrow-parens": false,
    "semicolon": false,
    "strict-boolean-expressions": false,
    "space-before-function-paren": false,
    "trailing-comma": [
      true,
      {
        "multiline": {
          "objects": "always",
          "arrays": "always"
        },
        "esSpecCompliant": true
      }
    ]
  },
  "rulesDirectory": []
}

but when I use hooks improperly it shows as a warning.

I would expect this to be underlined in red as an error.

[Grzegorz Rozdzialik]

That seems peculiar. I will try to replicate the issue and debug it 😄 Thanks for sharing 👍

[Illia Panasenko]

did you try "react-hooks-nesting": true?

[Tyler Haas]

yes I've tried all options.

[Grzegorz Rozdzialik]

@tylerthehaas I tried to replicate the issue. When using TSLint plugin for vscode the violations showed only as warnings. That is because this is the default behavior for this extension. Try to add:

"tslint.alwaysShowRuleFailuresAsWarnings": false

to workspace/user settings in VSCode. This made it so that the rule violations were shown as errors.

If that does not do it, try to lint your project using the command line and see if the violations are still warnings, not errors. Here is the output from my attempt:

λ npx tslint -c tslint.json -p tsconfig.json src/**/*.tsx

ERROR: D:/Programowanie/open-source/tslint-react-hooks-test/src/App.tsx:8:5 - A hook cannot be used in a class component

Make sure the behavior is correct for other rules you use. It may be that this problem is not specific to tslint-react-hooks, but to your overall environment configuration 🙂

[Grzegorz Rozdzialik]

@tylerthehaas Does the problem still appear, even after following my instructions from the post above?

[Tyler Haas]

I'm sorry I wasn't notified of your previous message. I will try at work tomorrow.

[Grzegorz Rozdzialik]

@tylerthehaas any progress? 🙂

[Tyler Haas]

sorry about the delay. but yes that fixed the issue. Would you like me to submit a pr to add that to the documentation?

[Grzegorz Rozdzialik]

No worries 🙂 That was not a problem with this specific rule, but with the vscode extension, so I would rather not add that information to this project as it is not closely related

Thank you for your effort 👍