Not warning about custom hooks as properties

[Esa-Matti Suuronen]

This should warn

if (cond) {
    MyHooks.useHook();
}

like this does

if (cond) {
    React.useEffect();
}

[Harry Cruse]

This is a deliberate decision from eslint-plugin-react-hooks to prevent false positives

If you import the function and use it directly then it will work

import { useHook } from 'MyHooks';

if (cond) {
  useHook(); // This will have a warning
}

And if you check the docs, they tend to do this with the default hooks too, rather than using e.g. React.useEffect()

[Grzegorz Rozdzialik]

@CruseCtrl Thank you for the explanation.

When implementing this rule, I strictly followed each heuristic that was made in eslint-plugin-react-hooks. Detecting using namespaced hooks is one of them.

If the eslint plugin changes this logic, I will try to update this project accordingly 🙂 For now, I am closing this issue to keep the behavior as is, matching the original rule