Wrong loop logic when using LDE

Question

Wrong loop logic when using LDE

CySHell opened this issue 3 years ago · comments

Inside ept.c, when counting the number of instruction bytes at the start of the hooked function, the instruction pointer is not incremented - this results in counting the length of the same instruction over and over again.

SizeOfHookedInstructions += LDE(TargetFunction, 64))

should be changed to something like:

SizeOfHookedInstructions += LDE(TargetFunction + SizeOfHookedInstructions, 64))

Gbps · Answer 1 · Mon Feb 22 2021 23:32:48 GMT+0800 (China Standard Time)

Hey there, great find! Looks like it was overlooked but generally didn't have any issues because only one instruction's space was necessary for the example.

Could you submit a pull request so I can merge it into the main branch?

Thanks!

CySHell · Answer 2 · Tue Feb 23 2021 17:04:12 GMT+0800 (China Standard Time)

Sure, please give me authorization to create a pull request.

Gbps · Answer 3 · Wed May 05 2021 05:52:33 GMT+0800 (China Standard Time)

Sorry, I know this was from awhile ago, but anyone should be able to open a pull request and I can review it.