Extract general functionality to BaseClient
rxx opened this issue · comments
@Gazler I'm going to do it. I hope you have not done it yet?
Can you create some issues for future that I would plan my activity?
@mli-max My latest is the latest pushed version. I am just taking a look at the feasibility of including activesupport to allow pluralization when including resources.
Could you briefly summarize your plan for this issue?
@Gazler I plan to extract extension and site methods to base client module. It's a duplicate functionality
@mli-max, the attr_accessor calls can be abstracted out into into the client class or the clientable module.
I actually think it might make more sense to move the methods from client.rb into the clientable module, what do you think?
@Gazler What is the importance clientable module? Can we move it functionality to client.rb?
@mli-max Currently not much actually, the code could be moved into client.rb we can always make it a module again in future if there is a compelling reason to.
Go for it!
@Gazler May I add simplecov gem for coverage tests? Oh, we have 100% code coverage 👍
@mli-max simplecov is my preferred coverage gem. Add it in as a development dependency with ~>0.7 as the version. 💯