GW2Treasures / gw2api

Wrapper for the Guild Wars 2 API in PHP

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Add /v2/guild/:id endpoint

darthmaim opened this issue · comments

Add /v2/guild/:id endpoint

I have found no issue with adding this to GuildEndpoint:

public function get($id) { return $this->request([],'v2/guild/'.$id)->json(); }

I'm not sure if it violates some kind of design issue, but as far as functionality it works.

$api->guild()->get($guildID);

Its not that easy. /v2/guild/:id can be requested with an API key or without, we don't have any other endpoint behaving like that. I'm not sure what the best way to handle this case would be yet.