Gnome 46 support

Question

Gnome 46 support

aknarts opened this issue 4 months ago · comments

Describe the bug

With the update of the gnome-shell the extension broke. So far I have found that MessageTray.NotificationBanner got removed here https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3173 not sure yet what the replacement is or I would fix it myself.

GSConnect version

56

Installed from

GNOME Extensions website

GNOME Shell version

46

Linux distribution/release

Arch Linux

Milan Šťastný · Answer 1 · Sun Mar 24 2024 17:34:55 GMT+0800 (China Standard Time)

I see there is an assumption that everything works #1740 :)

Skythrew · Answer 2 · Sun Mar 24 2024 17:41:28 GMT+0800 (China Standard Time)

Same issue here on Arch, I'm investigating on the issue.

vinylSummer · Answer 3 · Sun Mar 24 2024 19:06:59 GMT+0800 (China Standard Time)

The extension broke for me too on Arch with gnome 46. After gsettings set org.gnome.shell disable-extension-version-validation true the error is TypeError: class heritage MessageTray.NotificationBanner is not an object or null.

Neo-29 · Answer 4 · Sun Mar 24 2024 19:13:58 GMT+0800 (China Standard Time)

Can confirm it's broken here on gnome 46

Andy Holmes · Answer 5 · Mon Mar 25 2024 03:43:35 GMT+0800 (China Standard Time)

Unless there is an additional issue to report here, this is a duplicate of #1762.

I see there is an assumption that everything works #1740 :)

Yes, this was likely tested during the release-candidate, or possibly just with a stale version before the relevant change landed.

Skythrew · Answer 6 · Mon Mar 25 2024 14:41:17 GMT+0800 (China Standard Time)

Seems like the only part of the extension not working is the notification part, causing it to crash. Indeed, as OP said MessageTray.NotificationBanner, which was used for notifications, got removed and should be replaced (as it is written in the commit message by GNOME) by Calendar.NotificationMessage. Thus, in order to have the extension working again, we have to reimplement the notification part with this new class.

Neo-29 · Answer 7 · Mon Mar 25 2024 16:05:08 GMT+0800 (China Standard Time)

I disagree.
Here NOTHING works on arch.

Skythrew · Answer 8 · Tue Mar 26 2024 02:23:00 GMT+0800 (China Standard Time)

Nothing works because the notification part makes the whole extension crash. If you try to debug it and reinstall the extension, just by changing MessageTray.NotificationBanner to Calendar.NotificationMessage (of course you need to import the calendar.js file), the only part of the extension not working will be notifications, the rest will work correctly.

Neo-29 · Answer 9 · Tue Mar 26 2024 02:24:58 GMT+0800 (China Standard Time)

I don't even have the button in gnome settings on the right.
I shall wait for a fix
Not a problem

Skythrew · Answer 10 · Wed Mar 27 2024 15:00:10 GMT+0800 (China Standard Time)

The fix proposed in #1767 is not complete. It only allows the extension to work correctly without the notification part working. The notification part needs a reimplementation with the new Calendar.NotificationMessage that I'm currently working on because otherwise, the extension will "crash" on each notification that should be received.