class heritage MessageTray.NotificationBanner is not an object or null
philipraets opened this issue · comments
Describe the bug
GSConnect fails to start on GNOME46, in the logs there is the following error:
Extension gsconnect@andyholmes.github.io: TypeError: class heritage MessageTray.NotificationBanner is not an object or null
@file:///home/%USER%/.local/share/gnome-shell/extensions/gsconnect@andyholmes.github.io/shell/notification.js:47:4
Steps to reproduce
Install latest version from Github
Restart gnome-shell
Expected behavior
No response
GSConnect version
Latest from github
Installed from
GitHub releases (zip file)
GNOME Shell version
46.0
Linux distribution/release
opensuse Tumbleweed
Paired device(s)
No response
KDE Connect app version
No response
Plugin(s)
No response
Support log
No response
Screenshots
No response
Notes
No response
I encountered the same bug yesterday, after installing Gnome 46 on openSUSE Tumbleweed.
Fortunately, the issue preventing loading the extension was pretty easy to fix. I just had to edit ./shell/notification.js, add a line
import * as Calendar from 'resource:///org/gnome/shell/ui/calendar.js';
and change line 48 to
}, class NotificationBanner extends Calendar.NotificationMessage {.
Edit: However, as @muhammad-ans noted, some notifications won't work yet.
This fix is causing issues with notifications, No notification displays
During my tests at some point I had a notification show up, but after some more testing today, I can replicate the behavior that no notifications are displayed when sending things back and forth between my devices.
Basically, I changed the above lines, because this commit removed NotificationBanner from messageTray, which was originally used by the extension. I'll probably have to dig deeper into the problem when I find some time.
