GRAAL-Research / deepparse

Deepparse is a state-of-the-art library for parsing multinational street addresses using deep learning

https://deepparse.org/

Pretrained model doesn't need to inherit from nn.Module

MAYAS3 opened this issue 4 years ago · comments

Marouane Yassine commented 4 years ago

https://github.com/MAYAS3/deepparse/blob/dbc7236ed31e3878487298adbe99967561501a75/deepparse/network/pre_trained_seq2seq.py#L14

since we us this class as a wrapper and we do not aim to optimize the pretrained models, we do not have to inherit from nn.module here

David Beauchemin commented 4 years ago

Uhm, no since we need to put the model in eval mode.

Marouane Yassine commented 4 years ago

It seems not necessary, #27 ?

David Beauchemin commented 4 years ago

See #29

Marouane Yassine commented 4 years ago

Oh I see... Right!