build error with PAL_BUILD_GFX9=OFF
zenyd opened this issue · comments
Build fails when setting -DPAL_BUILD_GFX9=OFF with:
/home/zenyd/Downloads/amdvlk/drivers/pal/src/core/device.cpp: In static member function ‘static bool Pal::Device::DetermineGpuIpLevels(Pal::uint32, Pal::uint32, Pal::uint32, Pal::HwIpLevels*)’:
/home/zenyd/Downloads/amdvlk/drivers/pal/src/core/device.cpp:176:10: error: ‘FAMILY_AI’ was not declared in this scope
case FAMILY_AI:
^~~~~~~~~
/home/zenyd/Downloads/amdvlk/drivers/pal/src/core/device.cpp:176:10: note: suggested alternative: ‘FAMILY_CI’
case FAMILY_AI:
^~~~~~~~~
FAMILY_CI
make[2]: *** [pal/src/CMakeFiles/pal.dir/build.make:180: pal/src/CMakeFiles/pal.dir/core/device.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:17635: pal/src/CMakeFiles/pal.dir/all] Error 2
I think this is missing
+++ b/src/core/device.cpp
@@ -173,7 +173,9 @@ bool Device::DetermineGpuIpLevels(
break;
#endif
#if PAL_BUILD_OSS4
+#if PAL_BUILD_GFX9
case FAMILY_AI:
+#endif
case FAMILY_RV:
pIpLevels->oss = Oss4::DetermineIpLevel(familyId, eRevId);
break;
because FAMILY_AI
only gets defined when PAL_BUILD_GFX9=ON
(see here)
it's building now, thanks!