wayland: use linux-dmabuf instead of wl_drm
emersion opened this issue · comments
amdvlk relies on the wl_drm Wayland protocol to find the DRM device used by the compositor. However, wl_drm is a Mesa-private, legacy protocol, and compositors are starting to drop support. amdvlk should use the standard linux-dmabuf protocol from wayland-protocols instead.
Thanks for the heads-up. This is tracked in GPUOpen-Drivers/pal#96.
Would implementing linux-dmabuf also allow Tearing on Wayland? Or is this unrelated?
Not super experienced with this. Sorry if that's a dumb question.
Done in 2024.Q4.1 release
In case anyone else comes across this and does a double-take, it's in the 2024.Q2.1 release notes, so I'm guessing Q4 was a typo. Anyway, thanks!
Sorry, this is a typo. The work is done in 2024.Q2.1 release
I am running AMDVLK 2024.Q2.3 and I am still getting the following error whenever I try to run a wayland application using AMDVLK:
wl_drm#44: error 0: wl_drm.create_prime_buffer is not implemented
Thanks for reporting the issue. We will check it further.
Hi @HurricanePootis, thanks for your report.
Could you please provide your wayland application or where I can download it?
I am running vkcube-wayland, which is apart of the Vulkan-Tools repository.
Also, for more information, I am running the amdvlk driver with the following build process:
cmake -H. -Bbuilds/Release64 \
-DCMAKE_BUILD_TYPE=Release \
-DBUILD_WAYLAND_SUPPORT=On \
-G Ninja
And, according to the default.xml file in the tar soure code, it is built with PAL commit GPUOpen-Drivers/pal@695337a.
Edit:
Here is vulkaninfo for my system with the AMDVLK driver
Any update on this? Kind of inconvenient for amdvlk not to work with modern wayland apps.