[llpc] amdvlk-2023.Q1.3 build is failing

[shivania2]

I am trying to build amdvlk-2023.Q1.3 and getting following error during build

FAILED: compiler/llpc/llvm/tools/lgc/interface/lgc/LgcDialect.h.inc
cd /usr/src/photon/BUILD/amdvlk-2023.Q1.3/x86_64-vmware-linux && /usr/src/photon/BUILD/amdvlk-2023.Q1.3/x86_64-vmware-linux/compiler/llpc/llvm/bin/llvm-dialects-tblgen -gen-dialect-decls --dialect lgc -I /usr/src/photon/BUILD/amdvlk-2023.Q1.3/llpc/lgc -I/usr/src/photon/BUILD/amdvlk-2023.Q1.3/x86_64-vmware-linux/compiler/llpc/llvm/include -I/usr/src/photon/BUILD/amdvlk-2023.Q1.3/llvm-project/llvm/include -I/usr/src/photon/BUILD/amdvlk-2023.Q1.3/llpc/lgc/../imported/llvm-dialects/include /usr/src/photon/BUILD/amdvlk-2023.Q1.3/llpc/lgc/interface/lgc/LgcDialect.td --write-if-changed -o compiler/llpc/llvm/tools/lgc/interface/lgc/LgcDialect.h.inc -d compiler/llpc/llvm/tools/lgc/interface/lgc/LgcDialect.h.inc.d
/usr/src/photon/BUILD/amdvlk-2023.Q1.3/llpc/lgc/interface/lgc/LgcDialect.td:33:21: error: Couldn't find class 'PointerType'
def BufferPointer : PointerType<7>;

Build command

      cmake -GNinja -S xgl -DLLVM_PARALLEL_LINK_JOBS=1 -DVKI_RAY_TRACING=OFF  -B builds/Release64
      cmake --build builds/Release64

[Wenqing Li]

could you check if the llpc's submodule llvm-dialects is up-to-date?

[shivania2]

Yes, llpc module llvm-dailects is up-to-date.
llvm-dialetcs commit: b716b5679d2d7c24e2d10ffac339a6672ebf25bf

[Sebastian Neubauer]

That’s the wrong commit for llvm-dialects.
2023.Q1.3 has llpc commit 1ecd9997579b962be571162931c9e38bd86bafad: https://github.com/GPUOpen-Drivers/AMDVLK/blob/v-2023.Q1.3/default.xml
And that references llvm-dialects commit 17aafec: https://github.com/GPUOpen-Drivers/llpc/tree/1ecd9997579b962be571162931c9e38bd86bafad/imported

[shivania2]

Thanks.