GEWIS / gewisweb

GEWIS Website

Home Page:https://gewis.nl

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Poll date input Y-m-d confusion

rinkp opened this issue · comments

commented

Current behaviour

Currently, the poll approval form indicates it is a YYYY-mm-dd date field.
Since a date picker is used, the final format depends on the localisation the browser users. When using Dutch in MS Edge, the browser prefers dd-mm-YYYY

'label' => $translator->translate('Expiration date for the poll (YYYY-MM-DD)'),
'format' => 'Y-m-d',

Desired behaviour

Less confusion, since most broeders support the date field now, I think the hint can be removed

-                    'label' => $translator->translate('Expiration date for the poll (YYYY-MM-DD)'),
+                    'label' => $translator->translate('Expiration date for the poll'),
                    'format' => 'Y-m-d',

Steps to reproduce

  1. Create a poll
  2. Click approve poll
  3. Observe end date input

Website version

v4.3.2 (404d9b7)

What operating are you seeing the problem on?

Windows

What browsers are you seeing the problem on?

Firefox, Microsoft Edge

Other information

Originally reported by the board. Good first issue, neither a bug nor a feature

@rinkp do you want to create the PR yourself?