Job postings: attachment URL always visible

[Rink]

Current behaviour

gewisweb/module/Company/view/company/company/jobs.phtml

Line 130 in cd42dec

 <?php if (null !== $this->localiseText($job->getAttachment())): ?> 

This statement seems to be always true resulting in the attachment URL to always be shown

Other layouts use a different check:

gewisweb/module/Company/view/company/admin-approval/job-approval.phtml

Line 202 in cd42dec

 <?php if (null !== ($attachment = $job->getAttachment()->getValueNL())): ?> 

Desired behaviour

The attachment hyperlink is only shown when there is an attachment that can be downloaded

Steps to reproduce

1. Open any of the job listings of https://gewis.nl/en/career/company/infiniot
2. The attachment button is visible
3. Clicking the attachment button results in a 403 for /data

Website version

cd42dec

What operating are you seeing the problem on?

Linux, Other

What browsers are you seeing the problem on?

Firefox

Other information

No response

[Tom Udding]

Caused by GH-1821.