Streamline checking abrogation/discharge dates

[Tom Udding]

Current behaviour

We use > and >= interchangeably, but we should use only one variant throughout the whole codebase.

In some other places, we do not even check whether an abrogation/discharge date is in the future; we only check null.

Desired behaviour

While meetings never happen at 00:00, the assumption in GEWISDB is that this is the case. As such, an abrogation/discharge is effective after 23:59:59.9999 the previous day. Therefore, we should always use > and not >=.

Steps to reproduce

N/A

Website version

latest

What operating are you seeing the problem on?

No response

What browsers are you seeing the problem on?

No response

Other information

gewisweb/module/Decision/src/Mapper/Member.php

Line 129 in 6710a7a

 ->andWhere('om.dischargeDate IS NULL'); 

gewisweb/module/Decision/src/Mapper/Organ.php

Line 30 in 6710a7a

 'abrogationDate' => null, 

gewisweb/module/Decision/src/Mapper/Organ.php

Line 48 in 6710a7a

 'abrogationDate' => null, 

gewisweb/module/Decision/src/Mapper/Organ.php

Line 61 in 6710a7a

 $qb->where('o.abrogationDate IS NOT NULL') 

gewisweb/module/Decision/src/Model/Member.php

Line 671 in 6710a7a

 return null === $dischargeDate || $dischargeDate >= $today; 

gewisweb/module/Decision/src/Model/Member.php

Line 858 in 6710a7a

 || $releaseDate >= $now 

gewisweb/module/Decision/src/Model/Member.php

Line 863 in 6710a7a

 || $dischargeDate >= $now 

gewisweb/module/Decision/src/Service/Organ.php

Line 389 in 6710a7a

 if (null === $install->getDischargeDate()) { 

[Tom Udding]

gewisweb/module/User/src/Permissions/Assertion/IsOrganMember.php

Line 71 in 7f402fe

 (null === $organMember->getDischargeDate() || $organMember->getDischargeDate() >= $now);