Double-clicking start.tscn when launched in Japanese does not check (cource 102.a)
cacapon opened this issue · comments
I'm submitting a...
- Bug report.
- Feature request.
Bug report
What is the current behavior?
I am unable to proceed with 102.a, page 3.
The double click on start.tscn required there was not recognized.
(Only when activated in Japanese)
What is the expected behavior?
I would prefer the course to be in a form that allows progression even if it is launched in Japanese.
Tell us the steps to reproduce the bug, and if possible share a minimal demo of the problem.
- select the language Japanese on the project selection screen.
- select Godot Tours 102.a. 3.
- go to the third page. 4.
- follow the instructions and Viewport switches to start.tscn, but it is not checked.
- progress becomes impossible because the next is not displayed.
Other
Information at time of confirmation
- MacOS 14.1.2
- Godot v4.2.0
- Godot Tour 0.3.1
Other information
I found this bug in the course and sent an issue to the plugin to see if it might affect others.
I also checked the Romanian and Chinese tours and they migrated fine.
Of course, English is not affected. (Why only Japanese...)
I know that at the moment there is an announcement to activate it in English.
So it may not be a bug but something included in the feature request.
I have identified the likely cause of the problem.
The check point in the course file is comparing the root name to the translated Start characters.
return 1 if scene_root.name == gtr("Start") else 0
.
In this case, scene_root.name is fixed to Start in all languages, but gtr("Start") changes depending on the language and is false.
(For example in Japanese, "Start" == "スタート", which is false).
The gtr here is considered unnecessary.
We will send a separate patch for the course repository since it is not a plugin-side fix.
I have been notified that the patch has been applied to the course repository, so I will close this issue.