FullstackAcademy / boilermaker

Code scaffold for projects

Home Page:https://www.youtube.com/watch?v=7bLSuTHH4Ag&list=PLx0iOsdUOUmn7D5XL4mRUftn8hvAJGs8H

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

New syntax needed with "history"

AlexandraBeautyman opened this issue · comments

I get these two browser errors:

Warning: Please use require("history").createBrowserHistory instead of require("history/createBrowserHistory"). Support for the latter will be removed in the next major release.

warnAboutDeprecatedCJSRequire.js:17 Warning: Please use require("history").createMemoryHistory instead of require("history/createMemoryHistory"). Support for the latter will be removed in the next major release.

Yep, users will see this deprecation warning, and it's quite confusing, cause the boilermaker code doesn't use CommonJS-style require, it uses ES6 import statements.

Screen Shot 2019-05-21 at 1 12 51 PM

I'll submit a quick PR to fix this. Thanks for making an issue!