Add clippy to CI
Braqzen opened this issue · comments
To improve the quality of Rust code we can add the following to CI
Hi @Braqzen Can i work on this issue ?
Hi @Braqzen Can i work on this issue ?
Sure, once clippy is added it will mean that Rust code needs to be updated to pass according to whatever clippy suggests.
Hey @Braqzen, I think i don't have the permission to push in the repo.
i created a branch ci/sobebar/added-clippy, and committed the changes but not able push
Hey @Braqzen, I think i don't have the permission to push in the repo.
i created a branch ci/sobebar/added-clippy, and committed the changes but not able push
You must fork the repo, create a branch, push to your branch and then submit a PR from your repo back to this repo
@Braqzen Created a PR, you can review it https://github.com/FuelLabs/fuel-bridge/pull/1179
After looking at your PR and the best place to put clippy I've come across this.
So it turns out we already have clippy and it was hidden away in another command.
I'm not a fan of this approach because it hides checks like this. Nevertheless, gotta close this issue since we already have clippy.
Sorry about that