Issues to solve before creating a official Wagtail PR
marteinn opened this issue · comments
Martin Sandström commented
I was asked by the Wagtail core team to create a PR where we merge wagtail-redirect-importer into Wagtail, before we can do this a couple of things needs to be sorted out, this is from top of my head:
-
Use Wagtails built in factories when constructing tests (to remove as many dependencies as possible) - Fix heroku bugs "Tmp file not found on Heroku"
- Measure code coverage and make sure we have tests for all admin actions
- Create tests for all formats supported by tablib
- Attribute external code better
- Fix issue with default value for format in CLI and use a valid format choice list
- Add support for offset and limit to handle large datasets
Interested in helping out sorting out these issues, ping me!
Martin Sandström commented
Regarding "Use Wagtails built in factories...", it seems I already built the project with Wagtails test suite in mind.