FriendsOfSymfony / FOSHttpCache

Integrate your PHP application with your HTTP caching proxy

Home Page:https://foshttpcache.readthedocs.io

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Unknown parameter "vcl_dir"

ddeboer opened this issue · comments

In Varnish 5.1, vcl_dir was deprecated in favour of vcl_path. Varnish 6.2 removes the deprecated parameter.

Unfortunately, we’re still supporting old Varnish versions (even 3). So either we drop support < 5.1 or we have to differentiate and use vcl_dir for old versions and vcl_path for new ones.

i'd prefer to support both. if this was only about varnish 3 i would consider dropping support for that, but if it also is about varnish 4 and 5.0, i'd prefer to chose the right thing. do you want to work on that? we already have the phpunit env variable for the varnish version, right?

we adjusted the VarnishProxy test tool to support both.