Version 2.5.3 breaks console application

Question

Version 2.5.3 breaks console application

leofeyer opened this issue 6 years ago · comments

The new ProxyUnreachableException exception which has been added in 7ca3f9e yesterday breaks my console application. I think it is fine not to have an HTTP cache on the command line, therefore this case needs to be handled differently IMHO.

Yanick Witschi · Answer 1 · Wed Oct 31 2018 20:00:07 GMT+0800 (China Standard Time)

Imho that's not a bug of FOSHttpCache. Invalidation should just not happen in this case. I mean you now get an exception but before you should have gotten a on a null object error because it was always null 😄

Leo Feyer · Answer 2 · Wed Oct 31 2018 20:14:18 GMT+0800 (China Standard Time)

Then maybe this is a problem of the InvalidationListener of the bundle?

https://github.com/FriendsOfSymfony/FOSHttpCacheBundle/blob/db0ed59150fc47b347d0d820b411c188b5435d9d/src/EventListener/InvalidationListener.php#L125-L130

David Buchmann · Answer 3 · Wed Oct 31 2018 20:31:30 GMT+0800 (China Standard Time)

ah, i think i see the problem. before, we did a loop. if there are 0 elements, the loop would never try to call anything on null. i think that exception should only be thrown if there are > 0 invalidation messages to be sent. I will make a fix.

Leo Feyer · Answer 4 · Wed Oct 31 2018 20:32:03 GMT+0800 (China Standard Time)

Thank you @dbu.

David Buchmann · Answer 5 · Wed Oct 31 2018 22:13:11 GMT+0800 (China Standard Time)

fixed in 2.5.4

Leo Feyer · Answer 6 · Wed Oct 31 2018 23:08:14 GMT+0800 (China Standard Time)

Wow, you are fast. 👍 Thanks a lot!