PHP 8 support

Question

jmsche opened this issue 4 years ago · comments

Feature Request

It would be nice to add support to PHP 8 :)

Several questions to raise here:

drop Symfony 3.4 support? last 3.4 bugfix release is next week IIRC
replace Travis with Github Actions?
what about phpstan? I see the CI allows failures for this run, but should it? maybe lower its level?

Vincent Langlet · Answer 1 · Sun Dec 13 2020 21:03:48 GMT+0800 (China Standard Time)

Do you want to work on this @jmsche ?

I see no real activity on this repo since one year. Is it still maintained @lsmith77 ? :)

Lukas Kahwe Smith · Answer 2 · Sun Dec 13 2020 21:07:06 GMT+0800 (China Standard Time)

I was never active on this Bundle (IIRC) but to the questions above:

yeah I am fine dropping support for 3.4, requiring 4.4+ and 5.1+ (or even 5.2+)
yeah Travis is dead for OSS :(
sure, feel free to tweak things, always better to make it pass and then slowly aim for higher levels

jmsche · Answer 3 · Sun Dec 13 2020 21:16:41 GMT+0800 (China Standard Time)

@lsmith77 Thanks for your answers :)

@VincentLanglet Feel free to work on this; my holidays started yesterday so I might find time for this, but I don't know when exactly :)

Vincent Langlet · Answer 4 · Sun Dec 13 2020 21:47:51 GMT+0800 (China Standard Time)

I was never active on this Bundle (IIRC)

Sorry, I didn't know who was maintaining this and you merged the last PR.