Add support for creating .gitignore from template

Question

Add support for creating .gitignore from template

jihchi opened this issue 4 years ago · comments

It seems like currently create-snowpack-app won't pick up .gitignore from template?

https://github.com/pikapkg/create-snowpack-app/blob/a795622011744fe8aee8e712b67704bac30edad8/packages/create-snowpack-app/index.js#L93-L96

Am I misunderstanding here? it would be nice if we can derive .gitignore from template if there is one.

Michael Stramel · Answer 1 · Thu Jul 02 2020 09:50:19 GMT+0800 (China Standard Time)

I've ran into issues with this in the past on generators, I can take a look here soon

Fred K. Schott · Answer 2 · Thu Jul 02 2020 12:56:00 GMT+0800 (China Standard Time)

Thanks @stramel ! Hopefully it's just that we're overwriting it naively. If a template provides their own, we should honor that

Michael Stramel · Answer 3 · Sat Jul 04 2020 03:31:35 GMT+0800 (China Standard Time)

@FredKSchott .gitignore has always been problematic in template generators. npm/npm#1862

The workaround that I have seen is for the template to have a gitignore or something like similar that we can handle as a special case and rename it. However, if a template doesn't do this, the file still becomes .npmignore.

I'm looking for direction on this.

Jihchi Lee · Answer 4 · Sat Jul 04 2020 10:15:26 GMT+0800 (China Standard Time)

Just FYI. create-react-app takes gitignore and rename it to .gitignore. (code reference)

Michael Stramel · Answer 5 · Sat Jul 04 2020 10:45:04 GMT+0800 (China Standard Time)

@jihchi yep, I remember participating in the issue that discussed the solution. Couldn't remember what it was though.