FrSkyRC / ETHOS-Feedback-Community

Feedback & suggestions are welcomed here for ETHOS by FrSky

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Trims to sub trims not adjusting other flight modes' trim values.

lthole opened this issue · comments

1.5.0 RC7

'Trims to sub trims' is not considering trims in other flight modes and is not adjusting the other flight modes' trim values.

Test setup:
Default flight mode = Cruise
Added Speed and Thermal flight modes on switch SE.

image

Manually added trims:
Speed = -1%
Thermal = +3.5%

image

With flight mode = Thermal, execute 'Move trim to sub trim'.

image

As can be see in the screenshot and in Outputs, the +3.5% trim in the Thermal flight mode was moved to Subtrim. The trim in Thermal is now 0% and the Subtrim is +3.5%. Now comes the problem: The trim for Speed is still -1%.

Now compare the channel values in Elevator Output.
Before due to sub trim = 0%
Cruise = 0%
Speed = -1%
Thermal = +3.5%

After
Cruise = 3.5%
Speed = 2.5%
Thermal = 3.5%

After executing 'Move trim to sub trims' the plane should fly the same as before, so the expected 'After' values should be:
After due to sub trim = 3.5%
Cruise trim = -3.5% i.e. effective 0%
Speed trim = -4.5% i.e. effective -1%
Thermal trim = 0% i.e effective +3.5%

Fixed for RC8