Giters

FossifyOrg / Phone

A handy phone call manager with phonebook, number blocking and multi-SIM support

Home Page:https://www.fossify.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Orientation to follow posture, not screen dimensions

verbunk opened this issue · comments

commented

Checklist

  • I made sure that there are no existing issues - open or closed - to which I could contribute my information.
  • I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
  • I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the contribution guidelines.
  • I optionally donated to support the Fossify mission.

Feature description

Addition of a setting, 'Follow Posture', which changes the nature of screen rotations and app component sizing.

Why do you want this feature?

While navigating through the app it will rotate itself to some preferred orientation per view without me rotating the phone. AFAICT this is based on screen to view size matching (closest aspect ratio?) b/w the contact list vs. dialer views. I would prefer the app not rotate and instead stay in the correct/upright orientation based on current phone posture.

Additional information

No response

commented
  1. What are your screen dimensions? Do you have a foldable phone with "square" screen?
  2. Do you encounter the same problem in other Fossify apps?
commented

It's a twin-screen type. Each panel is 1350w X 1800h. I just clicked around in every area I could find. As far as I can tell the phone in-call view is the only one that doesn't respond correctly. So no impact to Calendar / MMS / Contacts / Clock that I can see. That being said the Calendar has slightly awkward layout, it's not 50/50 making it split down the middle but that's a different repo / enhancement req. :)

commented

Can vouch. I use a Surface Duo as well.

commented

Addition of a setting, 'Follow Posture'

I don't think we need an option for this. It should respect the device orientation by default. The dialpad and call screens are currently hard coded to use portrait screen orientation, adding landscape layouts will fix the issue. This likely affects many other projects as many of the apps have hardcoded orientation in some places.