Also work with keyboard nav

Question

Also work with keyboard nav

TaoK opened this issue 4 years ago · comments

Tao Klerks commented 4 years ago

In VSCode most commands can be invoked with autocomplete at the Ctrl-Shift-P prompt.

When you select "Browse with Git Extensions" here, however, you get an error:

Command 'Browse with Git Extensions' resulted in an error (Cannot read property 'fsPath' of undefined)

Carl-Hugo Marcotte · Answer 1 · Tue Jul 14 2020 21:07:19 GMT+0800 (China Standard Time)

That error makes sense since the extension opens Git Extensions based on the current file or folder that you right-click. TBH, I never thought of that one.

That said, how would you have the command to work (both in a folder and in a workspace)?

Tao Klerks · Answer 2 · Fri Jul 17 2020 02:52:02 GMT+0800 (China Standard Time)

I would assume the most sensible thing would be to have the command look at the active window, to figure out the path of the file open there...? (When not invoked with a target file / folder)

Carl-Hugo Marcotte · Answer 3 · Sat Jul 18 2020 00:27:04 GMT+0800 (China Standard Time)

How about the following?

For a folder: open the folder's git repo
For a workspace: have the user choose what folder's git repo to open

EDIT:

I forgot "orphan files": if the last file that has the focus was an "orphan", run the command against that file.

Carl-Hugo Marcotte · Answer 4 · Sat Jul 18 2020 00:28:14 GMT+0800 (China Standard Time)

Is this something that you or others would use? If yes, what's your use-case?

I don't mind looking into this when I have the chance, but only if it is useful, not as a missing feature that no one will ever use or care.