Quality plugin <hdr not working

[diogosena]

Expected behaviour:

"<hdr" should work similar as "<2160p"

Actual behaviour:

"<hdr" does nothing, as a workaround <=10bit seems to work

Steps to reproduce:

• Step 1: ...

Config:

  cache-low-quality-movies:
    priority: 10
    template:
      - disable-seen-retry
    list_clear:
      what:
        - movie_list: low-quality-movies
    entry_list: filesystem-movies
    quality:
      - <2160p
      - <hdr
    accept_all: yes
    list_add:
      - movie_list: low-quality-movies

Log:

(click to expand)

2024-03-15 11:38:45 VERBOSE  task          cache-low-quality-movies REJECTED: `AAAAAAAAAA.2160p.ATVP.WEB-DL.DDP5.1.Atmos.DV.HEVC-CMRG` by quality plugin because `2160p webdl h265 dolbyvision dd+5.1` does not match any of quality requirements: `<2160p`, `<hdr`
2024-03-15 11:38:45 VERBOSE  task          cache-low-quality-movies REJECTED: `BBBBBBBBBBB.2023.2160p.WEB-DL.DDP5.1.Atmos.DV.HDR.H.265-FLUX` by quality plugin because `2160p webdl h265 dolbyvision dd+5.1` does not match any of quality requirements: `<2160p`, `<hdr`
2024-03-15 11:38:45 VERBOSE  task          cache-low-quality-movies ACCEPTED: `CCCCCCCCCCC.2160p.DSNP.WEB-DL.DDP5.1.HDR.x265-NoGrp` by accept_all plugin
2024-03-15 11:38:45 VERBOSE  task          cache-low-quality-movies ACCEPTED: `DDDDDDDDDDD.2023.2160p.HDR.NF.WEB-DL.ENG.ITA.HINDI.Multi.Sub.DDP5.1.Atmos.x265.MKV-BEN.THE.MEN` by accept_all plugin

Additional information:

• FlexGet version: 3.11.23
• Python version: 2.10.12
• Installation method: pip
• Using daemon (yes/no): no
• OS and version: Ubuntu

[BrutuZ]

HDR can be either 10-bit or 12-bit, use !hdr instead

[diogosena]

HDR can be either 10-bit or 12-bit, use !hdr instead

quality plugin should be able to get lower qualities using < , your sugestion doesn't work at all,

2024-03-15 12:14:29 CRITICAL manager could not determine a constructor for the tag '!hdr' in "", line 247, column 9: - !hdr ^

[BrutuZ]

I apologize, misremembered my config 🙇
I have <hdr on a task and at some point it was !10bit (I commented it out)

[diogosena]

I apologize, misremembered my config 🙇 I have <hdr on a task and at some point it was !10bit (I commented it out)

By the way, acording to the documentaion, your suggestion should also work, that's probably another related bug.

[BrutuZ]

Just for clarification, list requirements in quality are evaluated separately.
A 1080p HDR release would not be rejected because it fits the <2160p requirement, same for a 4k 8-bit entry matching the <HDR requirement
If the entry should be neither 4k nor HDR it must be a single line requirement quality: <2160p <hdr

[diogosena]

Just for clarification, list requirements in quality are evaluated separately. A 1080p HDR release would not be rejected because it fits the <2160p requirement, same for a 4k 8-bit entry matching the <HDR requirement If the entry should be neither 4k nor HDR it must be a single line requirement quality: <2160p <hdr

The task is supposed to accept all low quality items of library (<2160p or <hdr), it's working as intended with the <=10bit workaround instead of <hdr .