FlashpointProject / launcher

Launcher for Flashpoint Archive

Home Page:https://flashpointarchive.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[Feature Request] Generate new entry UUID only if the curation's UUID already exists in the database

n0samu opened this issue · comments

Is your feature request related to a problem? Please describe.
Right now, there are 2 options for handling curation archive UUIDs (controlled by the "Keep Curation Archive UUID" switch):

  1. Generate a new entry UUID for every curation when importing.
  2. Retain every curation's UUID (specified by its folder name) when importing.

Option 1 is what BlueMaxima currently uses when adding games to Flashpoint. This is a problem because fixes cannot be submitted for games until they have an official, known ID in the Flashpoint database, which can take months.
Option 2 is unsuitable because a lot of curators mistakenly submit multiple curations with the same ID (because they copy and paste the curation folder to make a new curation). So BlueMaxima would have to respond to a lot of warning popups like this, which would slow him down too much:
image

Describe the solution you'd like
For option (1), instead of generating a new UUID for every imported entry, it should check the database first and generate a new UUID only if the curation UUID matches an existing UUID in the database. And the launcher should log that it generated a new UUID for that curation, so BlueMaxima can check back later.
To reflect the new behavior, the "Keep Curation Archive UUID" switch should be renamed to something like "Generate New UUIDs When Necessary". When switched off, behavior would match option (2). When switched on, behavior would match the new option (1).

Describe alternatives you've considered
Not an alternative per se, but a "Regenerate UUID" button on the Curate tab might be helpful for curators who like to copy and paste curation folders. They could continue curating the way they currently do, but avoid submitting problematic curations by clicking the button before exporting.

Additional context
To prevent users from submitting curations with duplicate UUIDs, we should also consider adding a check for it to FPFSS.