Giters

FitzwilliamMuseum / fitz-collection-online

A repository to hold the code for the front end/API of the Fitzwilliam Museum's Collections Explorer

Home Page:https://data.fitzmuseum.cam.ac.uk

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Linked Art representation - 404 on agents

portableant opened this issue · comments

commented

Within the linked art representation, a routing error was made - terminology rather than agents was used. Thus this code block is rendered:

"carried_out_by": [
      {
        "id": "https://data.fitzmuseum.cam.ac.uk/id/terminology/agent-161737",
        "type": "Person",
        "_label": "Trajan (AD 98-117)",
        "referred_to_by": [
          {
            "id": "https://data.fitzmuseum.cam.ac.uk/id/object/104030/maker/ccb09c30-adb3-3185-b5b4-e784e6fb613b",
            "type": "Type",
            "_label": "Ruler",
            "classified_as": [
              {
                "id": "https://data.getty.edu/local/thesaurus/producer-role-statement",
                "type": "Type",
                "_label": "Artist/Maker (Producer) Role Statement"
              },
              {
                "id": "http://vocab.getty.edu/aat/300418049",
                "type": "Type",
                "_label": "Brief Text"
              }
            ],
            "content": "Artists (Visual Artists)",
            "close_match": {
              "id": "http://vocab.getty.edu/aat/300025103",
              "type": "Type",
              "_label": "Artists (Visual Artists)"
            }
          }
        ],
        "close_match": [
          "https://nomisma.org/id/rome",
          "https://sws.geonames.org/3169070",
          "https://www.wikidata.org/entity/Q220",
          "https://pleiades.stoa.org/places/423025",
          "http://vocab.getty.edu/page/tgn/7000874"
        ]
      }

This should render as:

"carried_out_by": [
      {
        "id": "https://data.fitzmuseum.cam.ac.uk/id/agent/agent-161737",
        "type": "Person",
        "_label": "Trajan (AD 98-117)",
        "referred_to_by": [
          {
            "id": "https://data.fitzmuseum.cam.ac.uk/id/object/104030/maker/ccb09c30-adb3-3185-b5b4-e784e6fb613b",
            "type": "Type",
            "_label": "Ruler",
            "classified_as": [
              {
                "id": "https://data.getty.edu/local/thesaurus/producer-role-statement",
                "type": "Type",
                "_label": "Artist/Maker (Producer) Role Statement"
              },
              {
                "id": "http://vocab.getty.edu/aat/300418049",
                "type": "Type",
                "_label": "Brief Text"
              }
            ],
            "content": "Artists (Visual Artists)",
            "close_match": {
              "id": "http://vocab.getty.edu/aat/300025103",
              "type": "Type",
              "_label": "Artists (Visual Artists)"
            }
          }
        ],
        "close_match": [
          "https://nomisma.org/id/rome",
          "https://sws.geonames.org/3169070",
          "https://www.wikidata.org/entity/Q220",
          "https://pleiades.stoa.org/places/423025",
          "http://vocab.getty.edu/page/tgn/7000874"
        ]
      }

Simple fix for this within two files - app/LinkedArt/ObjectOrArtwork.php and app/LinkedArt/Production.php with the route changed from

'id' => route('terminology', ['id' => $maker['admin']['id']]),

to

'id' => route('agent', ['id' => $maker['admin']['id']]),
commented

Stale issue message

commented

Still needs merging.