isNumber not defined in IE

Question

isNumber not defined in IE

mival opened this issue 6 years ago · comments

Version info

DEBUG: -------------------------------
DEBUG: Ember      : 2.18.0
DEBUG: Ember Data : 2.18.0
DEBUG: Firebase   : 3.9.0
DEBUG: EmberFire  : 0.0.0 (2.0.9 from package.json)
DEBUG: jQuery     : 3.3.1
DEBUG: -------------------------------

Test case

Open emberfire project in IE 11.

Steps to reproduce

Open emberfire project in IE 11. When making store query on emberfire it crash.

Expected behavior

It should not crash

Actual behavior

It crash on isInteger call, https://github.com/firebase/emberfire/blob/master/addon/adapters/firebase.js#L323

I suggest add polyfill for isInteger https://developer.mozilla.org/cs/docs/Web/JavaScript/Reference/Global_Objects/Number/isInteger#Polyfill