Giters

FileOnQ / Imaging.Raw

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Fix Benchmarks

SkyeHoefling opened this issue · comments

commented

Description

The benchmarks started failing from PR #31 which doesn't make complete sense as that was just github templates.

Expected Behavior

Ensure benchmarks run successfully

Steps To Reproduce

There are a couple way to run the benchmarks

  • Submit a PR and wait for benchmarks to run (this will run the benchmarks from your current branch)
  • Using the /benchmark command in any PR (this will run the benchmark.yml from the main branch, but invoke the benchmarks from your current branch)

Environment

- CI
commented

I found this which looks to be a very similar issue to ours: actions/checkout#36

commented

@Bett-A-Fish thanks for the mind push - I just fixed this in fileonq/imaging.heif to support benchmarking on forked repositories. I pushed a lot of my changes straight to main to fix that because of how the benchmarking works. As far as I understand we will need to update the GitHub action to capture the correct ref and pass that to the various jobs. See the code below

https://github.com/FileOnQ/Imaging.Heif/blob/3c0f5b1f4d07534bf7dd35f8ace4155883b0b0d9/.github/workflows/benchmark.yml#L33-L56

Do you want to take a look and PR this? If so I can assign this one to you