Falicon / BitlyPHP

A simple PHP library for interacting with the Bit.ly API (including the new OAuth endpoints)

Home Page:http://falicon.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Provide mechanism to configure outside of editing the file

greggles opened this issue · comments

Currently the defined constants can only be used/configured by modifying the bitly.php file. That makes it harder to upgrade or present a browser-based user-interface to a site admin to configure their username/keys/etc. I propose switching to some alternate method of setting these bits of information.

I can imagine a few ways to make this information external to that file, but thought I would start the issue to discuss them and see if you have a preference. The one that seems most right is to switch the code to being Object Oriented and putting the required bits of info into the constructor (e.g. bitly_clientid) and the optional bits should have setter methods (e.g. bitly_api).

Thoughts?

I'm not sure if this has been fixed or I was just confused about how the code worked, but this appears to not be an issue. So....closing it :)