FairwindsOps / polaris

What happened?

Polaris audit failed because the helm chart's directory is an invalid release name.

That is, this command led to this error:

polaris audit --helm-chart helm/charts/proj --helm-values helm/values/test_values.yaml

ERRO[0002] Error: release name "helm/charts/proj": invalid release name, must match regex ^[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*$ and the length must not be longer than 53 
INFO[0002] Couldn't process helm chart: exit status 1

What did you expect to happen?

I expected the chart directory to not be substituted in as the helm release name.

How can we reproduce this?

I expect it should be easy enough. Looks like the chart directory is being substituted as the helm release name.

Version

7.3.0

Search

I did search for other open and closed issues before opening this.

Code of Conduct

I agree to follow this project's Code of Conduct

Additional context

No response

Yep, it's right here:

polaris/cmd/polaris/audit.go

Line 146 in bf065f9

helmChart,

. The helm chart's directory is being passed to Helm as the release name. That should, instead, be auto-generated randomly-ish. Helm already provides that, it should just say --generate-name there.

Polaris giving helm chart directory to helm as release name