Handle connection errors

Question

Handle connection errors

vikramsg opened this issue a year ago · comments

Hi,

This is a very nice project which I had been trying to use for my project. However, occasionally I hit the following error.

 ('Connection aborted.', ConnectionResetError(54, 'Connection reset by peer'))

Usually, something like this can be handled by backoff, for example, in the Request class from urllib3. Would including this be interesting to you? Happy to contribute towards this.

Leona Maroni · Answer 1 · Wed Jun 14 2023 05:10:26 GMT+0800 (China Standard Time)

Hey,
I currently don't have the time to implement this, but am happy to accept a PR :)
I'm not 100% sure how a good way of implementing would be, maybe a variable with a default on the profile class(es).

Just out of interest: With which profile did the error occur?

Vikram · Answer 2 · Wed Jun 14 2023 05:16:36 GMT+0800 (China Standard Time)

With which profile did the error occur?

This is with the DBProfile.

I'm not 100% sure how a good way of implementing would be, maybe a variable with a default on the profile class(es).

I haven't looked at it in detail but I would think an optional parameter with retries and backoff_factor would need to be set somewhere and all requests calls should use this.

Vikram · Answer 3 · Fri Jun 16 2023 18:28:51 GMT+0800 (China Standard Time)

Added a PR for this.

#31

Leona Maroni · Answer 4 · Sun Jul 02 2023 03:20:09 GMT+0800 (China Standard Time)

Now solved in #31, thanks to you!