Improve data resiliency of PersistentState
raoulvdberge opened this issue · comments
Currently, PersistentState is not safe to use because if a crash/unexpected power loss happens and there's a large PersistentState that takes a large amount of time to write to disk, it could end up only being partially written and then fail to deserialize on startup.
This has been fixed in NeoForge via following PR: neoforged/NeoForge#1001
Refined Storage is currently having following PersistentState implementation as a stop-gap solution: https://github.com/refinedmods/refinedstorage2/blob/develop/refinedstorage-platform-common/src/main/java/com/refinedmods/refinedstorage/platform/common/support/AbstractSafeSavedData.java
As discussed if we make this change it should only apply to mods, and not effect the vanilla states. How we actually determine this is not super clear to me though.