FLEXTool / FLEX

An in-app debugging and exploration tool for iOS

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[Buck] Error: file not found with <angled> include; use "quotes" instead

matrush opened this issue · comments

Environment

  • Platform+version: iOS 15
  • FLEX version: 4.6.1

Bug Report

Got a lot of error like this after this change 2f9f266
I'm using BUCK so it's probably not the exact environment that the projects uses by default, however it would still be good to fix for all.

error: 'FLEXDefaultsContentSection.h' file not found with <angled> include; use "quotes" instead
#import <FLEXDefaultsContentSection.h>

We should be using #import "xxx.h" instead of #import <xxx.h> as the latter look only in the standard system directories.
See
https://gcc.gnu.org/onlinedocs/cpp/Search-Path.html
https://stackoverflow.com/questions/21593/what-is-the-difference-between-include-filename-and-include-filename

This change was made to appease SPM I believe; could really use some help here, I'm not sure how to reconcile the imports and build settings in a way that makes all build systems happy 😵‍💫

This change was made to appease SPM I believe; could really use some help here, I'm not sure how to reconcile the imports and build settings in a way that makes all build systems happy 😵‍💫

What does SPM requires? It is not happy with #import "xxx.h"?

Not for the framework headers it's not

Are you building FLEX as a standalone target or are you including the source directly in your project?

I think #597 may resolve this; closing for now, feel free to reopen if the issue persists