Error when using prefab
fight4dream opened this issue · comments
Environment
- Code version: #83
- Platform version: Unity 2021.3.15f1
- 3rd party dependencies: Oculus Integration v50
Steps to reproduce
using the CameraRigs.OculusIntegration Prefab
Current behavior
NullReferenceException: Object reference not set to an instance of an object
Tilia.SDK.OculusIntegration.Tracking.CameraRig.OVRPluginDetailsRecord.OnEnable () (at Library/PackageCache/io.extendreality.tilia.sdk.oculusintegration.unity@2.1.2/Runtime/SharedResources/Scripts/Tracking/CameraRig/OVRPluginDetailsRecord.cs:58)
That line is
passthroughLayer.hidden = PassthroughLayerHiddenOnEnable;
there is no OVRPassthroughLayer on the ovr camera rig by default and our script didn't do a null check
the OVR Passthrough Layer setup is optional, so we better provide null checking
https://developer.oculus.com/documentation/unity/unity-passthrough/#create-passthrough-layer
also notice that we can add multiple of the passthrough layers (up to 3 instances can be active at any given time)
so i urge to review the logic of this portion whether it is needed to expand the variable into a list
yeah using a list may be a better idea
fixed #86
oh actually i need to do the list thing too
Here's the multiple lists, I just need to test it on the headset.
#87
🎉 This issue has been resolved in version 2.2.0 🎉
The release is available on:
Your semantic-release bot 📦🚀