Giters

ExtendRealityLtd / Tilia.Interactions.Interactables.Unity

A variety of mechanisms for interacting between interactors and interactables in a spatial scene for the Unity software

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Ungrabbing and distance checks become invalidated with slide movement.

HugoCortell opened this issue · comments

commented

NOTE: Any issue that does not follow the below template will be immediately closed and not re-opened until the template structure is adhered to.

Pre-check

  • Do not use the issues tracker for help or support, instead try the official Slack channel, official forum or Stack Overflow.
  • Do a quick search and make sure the issue has not already been raised, if it has then add to the existing issue if required.

Environment

  • Code source: Here, well, the json file at least.
  • Code version: Submitted screenshot since it might involve multiple repos (?)
  • Platform version: 2019.4.1f1
  • 3rd party dependencies: as listed above

Steps to reproduce

  1. set up an interactable (cube) with Follow Rigidbody
  2. in its RigibodyVelocity, set Max Distance Delta to 0.1 so that it 'feels heavy'
  3. hook its Diverged event to Ungrab(0) itself and enable Track Divergence
  4. add the AxisMove Slide prefab
  5. grab the cube, without moving by axismove, try to exceed the divergence threshold. the cube should ungrab itself
  6. grab the cube, move by axismove till exceed divergence threshold.

Expected behavior

The cube should ungrab itself, the distance is past the threshold.

Current behavior

The cube stays grabbed and will not trigger divergence.

Video

As always here is a video, this time with the console (it screams AAAAA each time divergence has been triggered) (at the time I did not know what caused it and as such I spend a bit of time trying to reproduce it) https://gofile.io/d/x5YbH0

commented

Can't recreate.

I've added a slide axis move prefab and when i grab the cube and slide away using the thumbstick it detaches as expected.

commented

Can't recreate.

I've added a slide axis move prefab and when i grab the cube and slide away using the thumbstick it detaches as expected.

I just spent two hours QAing over and over again to see if I could consistently recreate the bug (it usually took me anywhere between 5 to 15 tries to get it to break, now I can do it in 1 - 2) and I got it!

It might not be related to slide movement, if you grab the cube and twist your wrist 90 degress (try to tip over the cube with just wrist movement), the bug will appear instantly.
I would be more than happy to share another recording, hell id even send the project if necessary.

PS. I updated every single tilia package too!

commented

I can recreate it now

commented

I think I know the problem, and i think i have a fix for it. i'll post the PR when I've got round to getting the fix up

commented

It is incredibly joyous to hear that! Thank you!

commented

PR to fix: #40

commented

Id like to mention that the fix did work! But...
It also appears that now it misbehaves in a different way.

At first, it works perfectly! (Set it to 0.5 instead of 0.15 divergence threshold so its easier to tell the difference).
But then I grab and try to move away and it breaks the threshold.
It still grabs, but will then near-instantly ungrabs!

VIDEO: https://cdn.discordapp.com/attachments/716792975228665868/738912645226430544/penispenispenispenis.mp4
My packages (up to date): https://cdn.discordapp.com/attachments/716792975228665868/738904873889955920/unknown.png

Also, the getting stuck on the box part is unrelated to this issue, its got to do with the other issue iv posted.

commented

Thanks for re-opening it!

commented

Any update on this?

commented

When there's an update, it will be posted here