Search - Unable to hold expense from Search and console error shows up after trying to hold it
lanitochka17 opened this issue · comments
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.11-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:
- Go to staging.new.expensify.com
- Go to workspace chat
- Submit an expense
- Go to Search
- Click on the checkbox of the submitted expense
- Click on the dropdown
- Click Hold
- Enter reason and save it
- Click on the transaction on Search to open RHP
Expected Result:
The expense is held successfully when held via Search
Actual Result:
User is unable to hold expense when held via Search. Console error shows up after holding the expense and opening the RHP
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Bug6550744_1721753507776.bandicam_2024-07-24_00-48-21-804.mp4
Triggered auto assignment to @aldo-expensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
- Identify the pull request that introduced this issue and revert it.
- Find someone who can quickly fix the issue.
- Fix the issue yourself.
We think that this bug might be related to #wave-collect - Release 1
Following the steps, I get stuck with the search loading forever:
Ah, going back and going to the search again fixed it
the request is erroring when clicking "Hold":
Seems like the backend PR adding this command has not been deployed yet: https://github.com/Expensify/Web-Expensify/pull/42733
@luacmartins what do you think we should do? Seems like this functionality should have been put on HOLD until the backend is ready... but now that we are here, I guess we can just remove the deploy blocker, we will soon have the backend PR deployed anyway.
But then if we deploy App to production while the Web-E PR is still on staging, we'll have this issue again but on production. The ideal solution would be to CP that Web-E PR to staging and then prod IMO.
Oops there was a bit of a timing issue here. I agree with @francoisl we should just CP the web-e PR to prod. It's pretty low risk since it just adds a proxy to the Auth command.
Sounds good!
CP done and issue is fixed