[$250] [HOLD for Payment 2024-09-10][Search v2.1] [App] Create In filter
luacmartins opened this issue · comments
Implement this section of the design doc for the In filter only!
cc @adamgrzybowski @Kicu @WojtekBoman @Guccio163
Issue Owner
Current Issue Owner: @Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021833294167898155328
- Upwork Job ID: 1833294167898155328
- Last Price Increase: 2024-09-09
Triggered auto assignment to @RachCHopkins (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.
Already added to project.
@luacmartins do I need to do anything here? Sorry, I'm new to this team.
Not yet, you'll have to wait until we implement this and the issue is ready for payment.
@luacmartins, @RachCHopkins Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
Changing to monthly in that case!
The issue is still daily. We're looking for someone from SWM to take this on
@luacmartins, @RachCHopkins Whoops! This issue is 2 days overdue. Let's get this updated quick!
SWM will pick this up once the current wave of filter issues is done.
Sorry for delay, we missed this one. I’d like to work on this issue!
@luacmartins, @RachCHopkins, @rayane-djouah, @SzymczakJ Whoops! This issue is 2 days overdue. Let's get this updated quick!
I'll take this after I fix PR comments on #46736. I might also give it to somebody from SWM if I find free person.
Hi, I'm Wiktor Gut from SWM, I'll handle it so please assign it to me!
@luacmartins, @RachCHopkins, @rayane-djouah, @Guccio163 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
@luacmartins, @RachCHopkins, @rayane-djouah, @Guccio163 Still overdue 6 days?! Let's take care of this!
Not overdue, @Guccio163 is working on this
@luacmartins, @RachCHopkins, @rayane-djouah, @Guccio163 Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!
@luacmartins, @RachCHopkins, @rayane-djouah, @Guccio163 10 days overdue. Is anyone even seeing these? Hello?
this is still being worked on by @Guccio163 and I'm helping with it sometimes
PR is merged, but we still need to address this issue in a follow up
Hi, after research it looks like the filters' wrapping (issue above) is a matter of Text component, not even Advanced Filters one - it is just visible here, because of several MenuItems one under another in a single place. I'll look into it, hopefully it won't turn out to be a big one 🤞
cc: @luacmartins
@Guccio163 If that's an issue with the text component itself, I'm inclined to create a separate issue for it outside the search project. Would you mind writing a problem statement for it so we can get this issue created while we focus on search functionality?
@luacmartins Right now I'm consulting with SWM's android developers; I suspect this is a matter of how the shortening is implemented on Android and that their dynamics don't allow developers to enforce ending always exactly on the end of the available space, rather end earlier to not cut words randomly (what IOS supports and in this situation is better for us because it makes Texts aligned better).
I'll get back to you with possible solutions as soon as I'll be sure of our situation, right now the only possible (sensible) solution is to extend Android Native Text component to provide shortening like we need it, but this seems to be a big piece of work.
@luacmartins @rayane-djouah I think I might have found quite an elegant solution to this problem, I attach iPhone, Android and web comparison below, let me know if a result like this fullfills your expectations:
Note: Our problem solving approach at Expensify is to focus on high value problems and avoid small optimizations with results that are difficult to measure. We also prefer to identify and solve problems at their root. Given that, please ensure all proposed jobs fix a specific problem in a measurable way with evidence so they are easy to evaluate. Here's an example of a good problem/solution:
Problem: The Text component in MenuItem shortens the text too early and inconsistently.
Solution: Change MenuItem Text component's flex prop to 1, to force using all provided space and thus end in more or less the same place (depending on the content). We can change this behaviour in the whole app or only when using MenuItem in SearchAdvancedFilters, where the inconsistency is visible the most.
If we want this fix to be implemented in whole app this is a small change, I already made draft pull request to show the difference; From what I've checked, it shouldn't cause any bugs to previous usages, but I'll ask for QA tests in the issue dedicated for this bug.
@Guccio163 nice! Thanks for investigating this. I'm inclined to fix it in the whole App. This might lead to bugs, it's a really simple PR and easy to revert if needed. Let's do it.
Great, I'm waiting for an issue to link PR with then 😄
@Guccio163 created here. I linked the issue to the PR already
Note
The production deploy automation failed: This should be on [HOLD for Payment 2024-09-10] according to #48438 production deploy checklist, confirmed in #47676 (comment)
Payment is due today!
@luacmartins can I please confirm that this is a standard $250 via Upwork for @rayane-djouah? (@Guccio163 being from SWM)
Correct
Job added to Upwork: https://www.upwork.com/jobs/~021833294167898155328
Current assignee @rayane-djouah is eligible for the External assigner, not assigning anyone new.
I think I just sent you an offer @rayane-djouah but it did something a little strange - can you please confirm?
Oh, I see - it was because you were super duper fast.
Contributor has been paid, the contract has been completed, and the Upwork post has been closed.