ExpHP / thpages

touhou ANM site

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

React adoption checklist

ExpHP opened this issue · comments

Here I keep a list of things I need to come back to during the React refactor.

  • Make tips work again.
  • Use refractor to highlight
  • Replace globalNames with React state.
  • Completely exorcise data-name, data-link, NameResolver and LinkResolver.
  • Think about data-tip. Maybe we still need this?
  • Convert markdown extensions to components
  • Do we need to be more careful with reading window.location.hash?
  • delete postprocessConvertedMarkdown
  • Fix the copypasta at the bottom of the various tables.js
  • table-footnotes
  • look at remark-footnotes who cares
  • fix all tipshow/tiphide
  • render links
  • change all anchored headings to use {#id}
  • make sure there's no automatic header ids (probably an option somewhere)
  • why does the ins table have borders
  • Disabling of nested tooltips inside tooltip bodies needs to be reimplemented as a remark plugin (part of the :::is-tip logic)
  • fix highlighting of current page in navbar again
  • perform a check at runtime for any bad directives
    // find a custom element beginning with "exp-"
    let result = document.evaluate( "//*[starts-with(name(),'exp-')]", document, null, XPathResult.ANY_TYPE, null ).iterateNext();
    
  • change preventOverzealousTextDirectives into a plugin that operates only on text nodes changed the syntax to :ref{r=...} instead
  • how to reset scroll on new page?
  • scrolling to anchor
  • <div class="gear">
  • stats
  • layer viewer
  • couldn't parse ref :ref{r=anm:resampleMode tip=0}
  • 404 on bad page
  • "See the table entry for more details" was lost from tips

Things from the second rewrite:

  • Update the other tables besides STD
  • toolips are weirdly positioned due to async content...
  • settings page
  • markdown pages
  • truth maps
  • redirect to new HashRouter urls
  • fix old links in MD not using HashRouter urls
  • "Show more" has the wrong cursor again
  • HTML in MD not working

Things to double check at the end:

  • Check appearance of everything:
    • headless-table
    • table-footnotes
    • title
    • c
    • ref in inline-code: see resampleMode
    • tip with newlines in body: see furiTip
    • stats table
    • 404 on bad page
    • more...
    • embedded video
  • scroll positions:
    • follow link to instruction
    • follow link to instruction, hit back button (should go back to original scroll) (this was already broken)
    • with an anchor in the current url, scroll away from anchor, go to another page and hit back (should not return to anchor) (this was already broken)
    • with an anchor in current url, scroll away from anchor, and hit refresh (should not return to anchor) (this was already broken)
    • scroll down, navigate to other page: should reset scroll to top
    • follow a link to an instruction in the same table but another game (e.g. randMode)