Issue did not close
grandeljay opened this issue · comments
Hey, thanks for making this! It looks really cool.
I just started playing around with it and noticed that my issue did not close. Can you maybe tell what went wrong?
T better-commits
|
o Found repository config
|
o Checking Git Status
|
* Changes to be committed:
| .better-commits.json
|
o Select a commit type
| fix
|
o Select a commit scope
| yo momma
|
o Ticket / issue infered from branch (confirm / edit)
| 1
|
o Write a brief title describing the commit
| Calculate weight of yo momma
|
o Write a detailed description of the changes (optional)
| So far it has not been possible to compute the weight of your mom but now we know she is so fat.
|
o Select optional footers (<space> to select)
| closes <issue/ticket>, breaking change
|
o Breaking changes: Write a short title / summary
| Yo momma breaks everything she sits on
|
o Breaking Changes: Write a description & migration instructions (optional)
| Breaks chairs, sofas, and so on
|
o Commit Preview -----------------------------------------------------------------------------------+
| |
| fix(yo-momma)!: 1 Calculate weight of yo momma |
| |
| So far it has not been possible to compute the weight of your mom but now we know she is so fat. |
| |
| BREAKING CHANGE: Yo momma breaks everything she sits on |
| |
| Breaks chairs, sofas, and so on |
| |
| Closes: 1 |
| |
+----------------------------------------------------------------------------------------------------+
|
o Confirm Commit?
| Yes
I then merged the branch (fix/1-yo-momma-so-fat) via a merge commit: grandeljay/better-commits-test@643c432 but the issue did not close or was mentioned/linked in any way.
What did I do wrong?
I just watched the Video again, the issue needs to start with the # (duh). Sorry if I made your eyes bleed!
@grandeljay Hey no worries haha, thanks for trying it out! -- Just a heads up you can auto append the hashtag if you set check_ticket.append_hashtag to true.
Oh neat, thanks! That's awesome!
Just to be clear, you mean it needs to be set inside the better-commits.json?
Just to be clear, you mean it needs to be set inside the
better-commits.json?
I set the property there on my machine and it worked.